encoding/xml: wrongly rejects ]]> in attribute value

[DemiMarie]

Go version

Whatever https://go.dev/play uses

Output of go env in your module/workspace:

Whatever https://go.dev/play uses

What did you do?

https://go.dev/play/p/cxvESJwGocp

package main

import "encoding/xml"

func main() {
	err := xml.Unmarshal([]byte(`<a b="]]>"/>`), new(interface{}))
	if err != nil {
		panic("well-formed XML rejected")
	}
}

What did you see happen?

encoding/xml rejects an attribute containing ]]>.

What did you expect to see?

encoding/xml should accept attributes containing ]]>, as libxml2 does.

[gabyhelp]

Related Issues and Documentation

• encoding/xml: accepts XML with no space between attributes #68385
• encoding/xml: accepts various ill-formed XML #68293
• encoding/xml: disallow `xml:"foo>bar,attr'` #5033 (closed)
• encoding/xml: does not reject duplicate attribute names #68295
• encoding/xml: `,innerxml` values are not escaped. #16604 (closed)
• encoding/xml: decoding XML with entities not supported #30983 (closed)
• encoding/xml: CDATA section allows invalid characters #53728
• encoding/xml: does not reject multiple attributes with the same namespace URL and local part #68297

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/610056 mentions this issue: encoding/xml: allow ]]> in attribute values