Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: encoding/xml: reject directives by default #68459

Open
DemiMarie opened this issue Jul 16, 2024 · 0 comments
Open

proposal: encoding/xml: reject directives by default #68459

DemiMarie opened this issue Jul 16, 2024 · 0 comments
Labels
Milestone

Comments

@DemiMarie
Copy link
Contributor

Proposal Details

encoding/xml currently reads XML directives, but it doesn’t process them. Parsing XML DTDs is far too complex for encoding/xml. Furthermore, DTD processing is a frequent source of security issues. For instance, they are a required part of Billion Laughs and XML External Entity attacks, and they were also involved in a recent double-free in libxml2.

I propose that encoding/xml reject XML directives entirely by default. This is the only way I can see implementing #68299, and is consistent with recent versions of .NET.

@gopherbot gopherbot added this to the Proposal milestone Jul 16, 2024
@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Incoming
Development

No branches or pull requests

2 participants