x/tools/gopls: "invalid selection" bug in ExtractToNewFile

[adonovan]

#!stacks
"bug.Errorf" && "golang.ExtractToNewFile:+15"

Issue created by stacks.

// ExtractToNewFile moves selected declarations into a new file.
func ExtractToNewFile(ctx context.Context, snapshot *cache.Snapshot, fh file.Handle, rng protocol.Range) ([]protocol.DocumentChange, error) {
...	start, end, firstSymbol, ok := selectedToplevelDecls(pgf, start, end)
	if !ok {
		return nil, bug.Errorf("invalid selection") <---- here
	}

This stack 8PIcaw was reported by telemetry:

• gopls/bug
• golang.org/x/tools/gopls/internal/util/bug.report:+35
• golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
• golang.org/x/tools/gopls/internal/golang.ExtractToNewFile:+15
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ExtractToNewFile.func1:+1
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2:+3
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run:+77
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ExtractToNewFile:+1
• golang.org/x/tools/gopls/internal/protocol/command.Dispatch:+81
• golang.org/x/tools/gopls/internal/server.(*server).ResolveCodeAction:+21
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+46
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
• golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
• golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
• runtime.goexit:+0

golang.org/x/tools/[email protected] go1.23.4 darwin/arm64 neovim (1)

[gabyhelp]

Related Issues

• x/tools/gopls: "slice bounds out of range" crash in ExtractToNewFile #70553
• x/tools/gopls: DidModifyFiles: "failed to define view for open file" bug in selectViewDefs #70909 (closed)
• x/tools/gopls: "unexpected file: %q" bug.Report in bestView (reported by telemetry) #67288
• x/tools/gopls: "go/packages returned unexpected package %q for standalone file" bug in Snapshot.load #69895 (closed)
• x/tools/gopls: DidModifyFiles: "non-abs file path %q" bug in port.matches #70603
• x/tools/gopls: "inline: corrupted reference %v" bug in golang.RemoveUnusedParameter #69896 (closed)
• x/tools/gopls: bug: load.go:185: go/packages returned unexpected package "golang.org/x/tools/go/callgraph/cha/testdata/iface.go.master" for standalone file #69331 (closed)
• x/tools/gopls: "edit does not belong to syntax of package %q" bug in golang.Rename #70049
• x/tools/gopls: Rename: crash due to Info.Defs[id]=nil bug in checkStructField #70968
• x/tools/gopls: Hover: nil deref in parseDocLink #70635 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}