From 7ee572b8781ba2410a0e01cfbb2a106b91580891 Mon Sep 17 00:00:00 2001 From: Jonathan Amsterdam Date: Thu, 12 Dec 2024 18:15:14 -0500 Subject: [PATCH] internal/labels,labeleval: minor changes Recategorize some bugs and clarify the meaning of a category. After these changes, during one run, the only failure was 60017, classified as a language proposal instead of a bug. But arguably it _is_ a proposal ("Will be good to see composite literal being supported directly inside range expression"), even though one based on a misunderstanding. Other runs reported other failures; the results are not repeatable. For golang/oscar#64. Change-Id: I4a3338741c2be3f60fcb1f1007677765ca9f4f92 Reviewed-on: https://go-review.googlesource.com/c/oscar/+/635855 Reviewed-by: Hyang-Ah Hana Kim LUCI-TryBot-Result: Go LUCI Reviewed-by: Tatiana Bradley --- internal/devtools/cmd/labeleval/issues.txt | 10 +++++----- internal/labels/static/categories.json | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/devtools/cmd/labeleval/issues.txt b/internal/devtools/cmd/labeleval/issues.txt index fb66f9b..cf660b9 100644 --- a/internal/devtools/cmd/labeleval/issues.txt +++ b/internal/devtools/cmd/labeleval/issues.txt @@ -1,5 +1,5 @@ 69000 bug -69001 bug # but maybe a user misunderstanding? +69001 documentation # iant: "I think that is a genuine bug in the docs that we should fix." # 02 bot 69003 accessRequest # 04 bot @@ -28,15 +28,15 @@ 69027 libraryProposal # 28 bot # 29 bot -69030 proposal # adding a GODEBUG option +69030 libraryProposal # adding a GODEBUG option # 31 bot 69032 bug # or maybe WAI 69033 libraryProposal # 34 bot # 35 bot # 36 bot -69037 bug # WAI -69038 bug -69039 implementation +69037 workingAsIntended +69038 builders +# 69039 PR 69040 invalid diff --git a/internal/labels/static/categories.json b/internal/labels/static/categories.json index ba54a5e..4169d9a 100644 --- a/internal/labels/static/categories.json +++ b/internal/labels/static/categories.json @@ -13,7 +13,7 @@ { "Name": "libraryProposal", "Label": "LIBPROPLABEL", - "Description": "This issue describes a requested change to the Go standard library or x/ libraries. Adding build tags or " + "Description": "This issue describes a requested change to the Go standard library or x/ libraries, but not to a tool" }, { "Name": "toolProposal",