Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decouple gopls release and ci test #3166

Open
hyangah opened this issue Feb 8, 2024 · 0 comments
Open

chore: decouple gopls release and ci test #3166

hyangah opened this issue Feb 8, 2024 · 0 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 8, 2024

Currently CI runs the extension/tools/generate.go -gopls command and checks if the package.json setting section and documentation generated from the package.json are consistent with the latest release of gopls (including prerelease).
As a result we end up our CI test fails whenever gopls is released, regardless of whether the change makes changes to a feature that depends on gopls. This adds unnecessary burden and noise to contributors.

I propose to remove this gopls setting test from CI.

However, since the extension currently doesn't pin the gopls version, it's still important to detect changes and breakage that may be caused by gopls release timely. We can have a separate workflow that runs against the prerelase version of gopls, creates a cl automatically, and also opens an issue if the extension misbehaves with the latest gopls.

cc @golang/tools-team

@gopherbot gopherbot added this to the Untriaged milestone Feb 8, 2024
@findleyr findleyr modified the milestones: Untriaged, vscode-go/backlog Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants