-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repository management: determine prefixes for issues and changelists #83
Comments
For changes to files in Then, An alternative is the approach like https://www.conventionalcommits.org/en/v1.0.0/ , which allows variations of tools like https://github.com/googleapis/release-please that help automating part of the frequent release process. OTOH, we may use relnote for release note generation instead. In that case, the info can be done through |
Agree with that. Refactoring things so that CLs only affect single modules seems right to me. Having something to generate release notes would also be awesome - we could use it for |
Change https://golang.org/cl/234240 mentions this issue: |
We need extra rules for issues. Issues for bugs can use the same rule (culprit module name) if the source of the problem is obvious. Users may not know the actual implementation, so maintainers need to identify them if possible. But for issues that involve upstreams ( New feature requests may not fall into any of the existing modules. For them, 'proposal' or 'feature request'? (I think proposal is a more concrete form of feature request that may include discussion of design and implementation though). |
Would it perhaps make sense to go over the last X PRs and/or issues and classify and group them to see what categories are starting to emerge? |
The current de-facto convention is
We need to document this in https://github.com/golang/vscode-go/blob/master/docs/contributing.md |
The typical practice in the rest of the Go project is to prefix issues and CLs with the name of the package they pertain to. This doesn't really make sense for this repository, as there are no Go packages.
These issue prefixes are helpful for classification, so it'd be nice to stick with them, but we don't seem to have a consistent strategy for applying them.
doc
is useful for documentation changes, but the analogoussrc
for code changes is not really useful. We should restructure the code in such a way that we can have useful prefixes.Furthermore, for issues, I think we need to create prefixes, some of which may collide with existing labels. For example,
debug
is useful as a prefix for skimming issues quickly, but also useful as a label for quick searches./cc @hyangah
The text was updated successfully, but these errors were encountered: