Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tour: No information whether BST tree should be in/post/pre-order #158

Open
kmolon opened this issue Feb 1, 2017 · 0 comments · May be fixed by golang/website#202
Open

tour: No information whether BST tree should be in/post/pre-order #158

kmolon opened this issue Feb 1, 2017 · 0 comments · May be fixed by golang/website#202

Comments

@kmolon
Copy link

kmolon commented Feb 1, 2017

Context: https://tour.golang.org/concurrency/8

The output 1,2,3,4,... will only appear if we travers the tree in-order. Otherwise, the numbers might appear random. It would worth pointing that out in the description of the task.

crisman added a commit to crisman/golang_website that referenced this issue Feb 28, 2023
In "Exercise: Equivalent Binary Trees" neither the slide text nor the
code state Walk() should send the values in order. Doing so in order
makes using the output much more useful in Same(), but might not be easy
to see for readers that have not had a data structures class. In order
traversal is implied by reference with the binary tree being "always
sorted" and the output defined as "should be the numbers 1, 2, 3, ...,
10."

Update the slide text to say what Walk() does. Change Walk() comments in
code/solution to match.

Fixes golang/tour#158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant