Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domine ^ is zero-width #8438

Open
rsheeter opened this issue Oct 29, 2024 · 2 comments
Open

Domine ^ is zero-width #8438

rsheeter opened this issue Oct 29, 2024 · 2 comments
Milestone

Comments

@rsheeter
Copy link
Collaborator

https://fonts.google.com/specimen/Domine?preview.text=This%20is%20probably%20broken%20-%20%5E%5E%5E%5E%5E%5E%5E%5E%5E%5E%20-%20...and%20after

$ /oss/harfbuzz/build/util/hb-shape --text "^"  /oss/fonts/ofl/domine/Domine\[wght].ttf 
[asciicircum=0+0]

Suggests a collection scope check. My naive formulation was if most fonts that support a grapheme have it not-zero-width and a few have it zero that's suspect. @simoncozens suggested base glyphs shouldn't be zero width is also valid.

@kenmcd
Copy link

kenmcd commented Oct 29, 2024

asciicircum advance width on the Regular is 382.
But it is marked as a non-spacing mark.
If you change it to a Base it appears correctly.

@simoncozens
Copy link
Collaborator

I constructed a quick fontspector check which looks for

  • encoded glyphs
  • with advance width 0
  • which are not GDEF non-spacing marks
  • and which don't have Unicode categories Space Separator, Line Separator, Paragraph Separator, Format, Control or Nonspacing Mark.

We have 615 fonts in the collection which fail this check.

@emmamarichal emmamarichal added this to the Backlog milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants