New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fxlab should use std:shared_ptr and FullDuplexStream #2157

Open

philburk opened this issue Feb 7, 2025 · 0 comments

Labels

Collaborator

philburk commented Feb 7, 2025 •

edited

Loading

These changes are in one issue because the code for both changes are tightly coupled.

FXLab uses a custom DuplexCallback. It should use the new common class FullDuplexStream.
See LiveEffect for an example.

ManagedStream is deprecated and can lead to crashes.
Code in the DuplexCallback.

philburk mentioned this issue

Update DuplexCallback.h in fxlab #2136

Closed

philburk added enhancement P1 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment