Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric Labels in Graph views #234

Open
nolanmar511 opened this issue Sep 28, 2017 · 1 comment
Open

Numeric Labels in Graph views #234

nolanmar511 opened this issue Sep 28, 2017 · 1 comment
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request

Comments

@nolanmar511
Copy link
Contributor

Right now, only values associated with the "bytes" tag will ever be displayed in any call graph views.
This is because of the following section of code:
https://github.com/google/pprof/blob/master/internal/report/report.go#L244-L253

We should change how this works. For example, if there is no "bytes" tag for numeric data, we should use the first encountered numeric tag.

@nolanmar511
Copy link
Contributor Author

Tag being displayed could be noted in legend as "nodelete tag" or something similar.

@Louis-Ye Louis-Ye added type: feat Buganizer type - Feature Request Priority: p3 Buganizer priority - P3 Priority: p2 Buganizer priority - P2 and removed Priority: p3 Buganizer priority - P3 labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants