Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use atos on OSX when addr2line or llvm-symbolizer are not available #351

Open
aalexand opened this issue Apr 3, 2018 · 0 comments
Open

Use atos on OSX when addr2line or llvm-symbolizer are not available #351

aalexand opened this issue Apr 3, 2018 · 0 comments
Labels
Priority: p3 Buganizer priority - P3 type: feat Buganizer type - Feature Request

Comments

@aalexand
Copy link
Collaborator

aalexand commented Apr 3, 2018

This was mentioned in #130 which was closed since then so filing to track.

For pprof symbolization to work on OSX it currently requires installing binutils (for gaddr2line) or llvm (for llvm-symbolizer). It would be good if pprof knew how to use the atos utility which is installed by default.
@aalexand aalexand changed the title Use atos on OSX when addr2line or llvm-symbolizer are not available Use atos on OSX when addr2line or llvm-symbolizer are not available Apr 3, 2018
ankon added a commit to ankon/node-remote-pprof that referenced this issue Jul 2, 2018
@ankon
Add a reference to google/pprof#351
9aead5c 
We do have a parser for the atos output (in JS though, not Go), but that's really just based on my guesses as to what we need. google/pprof#351 is the matching ticket on the pprof repository that asks for atos support when `gaddr2line` (binutils) or `llvm-symbolizer` (llvm) are not available.

We should watch that ticket, and consider whatever is done there to be "canonical": Our implementation must match that.

Note: This doesn't mean we cannot contribute our implementation -- but we shouldn't own the parsing knowledge here.
@Louis-Ye Louis-Ye added type: feat Buganizer type - Feature Request Priority: p3 Buganizer priority - P3 labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: p3 Buganizer priority - P3 type: feat Buganizer type - Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aalexand @Louis-Ye