Settings has 'Enable groups' CTA instead of toggle

[kelvinballoo]

Bug Description

This was raised while testing #8577

• When we click on 'Settings' to deactivate this widget on a second admin, it brings up the 'Enable groups' button.
• By right, I would expect the toggle only at this point so that it can be turned on and off. You may refer to the 1m40 mark on the video below.

Steps to reproduce

• Set up Site Kit with the audienceSegmentation feature flag enabled, and click on Enable groups to set the feature up.
• Archive all of the audiences for the connected property barring "All Users".
• Login as a second admin user and connect Site Kit. The second admin should have view access or higher for the connected property.
• The banner copy says
  • 'You don't have any visitor groups selected. [Select groups]
  • You can deactivate this widget in [Settings]
• WHen clicking on 'Settings', you go to the settings but instead of having the toggle to turn it on or off, there is the 'Enable groups' CTA. (You may refer to the 1m40 mark on the video below)

Screenshots

8577.-.AUthenticated.user.test.720p.mov

Additional Context

• PHP Version:
• OS: [e.g. iOS]
• Browser: [e.g. chrome, safari]
• Plugin Version: [e.g. 22]
• Device: [e.g. iPhone6]

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Having run through the steps to reproduce, the Display visitor groups in dashboard toggle should appear in the Settings section, and the Enable groups CTA should not be present.

Implementation Brief

• Update the conditional rendering in SettingsCardVisitorGroups to test for the truthiness of configuredAudiences rather than testing configuredAudiences.length. I.e. change the following conditions to ! configuredAudiences and !! configuredAudiences respectively:

site-kit-wp/assets/js/modules/analytics-4/components/audience-segmentation/settings/SettingsCardVisitorGroups/index.js

Lines 74 to 75 in 40f5363

	{ ! configuredAudiences?.length && <SetupCTA /> }
	{ !! configuredAudiences?.length && (

Test Coverage

• Fix failing JS and VRT tests.

QA Brief

Changelog entry

[nfmohit]

IB ✅