Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize GA events for RRM Setup Success Subtle Notification #9368

Closed
1 task done
jimmymadon opened this issue Sep 18, 2024 · 1 comment
Closed
1 task done

Standardize GA events for RRM Setup Success Subtle Notification #9368

jimmymadon opened this issue Sep 18, 2024 · 1 comment
Labels
P0 High priority Team S Issues for Squad 1 Type: Bug Something isn't working

Comments

@jimmymadon
Copy link
Collaborator

jimmymadon commented Sep 18, 2024

Bug Description

The GA events fired when viewing, clicking on the CTA and dismissing the RRM Setup Success Subtle Notification has an event category mainDashboard_rrm-setup-success-notification. This is slightly different to the notification events that we have created already for Ads and PAX which are mainDashboard_setup-success-notification-pax and mainDashboard_setup-success-notification-ads.

Steps to reproduce

  1. Complete RRM setup and see the setup success subtle notification.
  2. The GA events for view, CTA click and dismiss button click are mainDashboard_rrm-setup-success-notification. They should be mainDashboard_setup-success-notification-rrm just to maintain consistency with other modules.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The GA event categories for the View, CTA Click and Dismiss button click should be modified for the RRM Setup Success Subtle Notification from <view-context>_rrm-setup-success-notification to <view-context>_setup-success-notification-rrm.

Implementation Brief

  • In assets/js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js, replace the event category as per the AC.

Test Coverage

  • No new tests required but update existing tests.

QA Brief

  • Ensure user analytics for Site Kit usage are enabled.
  • Complete RRM setup and test all the three GA events being fired on view, dismiss and CTA click.

Changelog entry

  • Update RRM notification event names in Analytics.
@jimmymadon jimmymadon self-assigned this Sep 18, 2024
@jimmymadon jimmymadon added P0 High priority Type: Bug Something isn't working labels Sep 18, 2024
@jimmymadon jimmymadon assigned tofumatt and unassigned jimmymadon Sep 18, 2024
@jimmymadon jimmymadon added the Team S Issues for Squad 1 label Sep 18, 2024
@tofumatt tofumatt removed their assignment Sep 18, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Sep 19, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified the GA event categories for the View, CTA Click and Dismiss button click now modified for the RRM Setup Success Subtle Notification from _rrm-setup-success-notification to _setup-success-notification-rrm.
  • Verified view_notifcation, dismiss_notification and confirm_notification (CTA click) events.
  • Verified when RRM setup get complete and status is onboard complete.
  • Verified when RRM setup get complete and status is pending verification.

View_Notiification

image

image

Confirm_Notification (CTA Click)

image

dismiss_notification

image

@mohitwp mohitwp removed their assignment Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Team S Issues for Squad 1 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants