Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errorprone adoption #3620

Open
schcamille opened this issue Jan 30, 2025 · 0 comments · May be fixed by #3621
Open

Errorprone adoption #3620

schcamille opened this issue Jan 30, 2025 · 0 comments · May be fixed by #3621
Assignees
@rahul2393
Labels
api: spanner Issues related to the googleapis/java-spanner API.

Comments

@schcamille
Copy link

Adopt the errorprone plugin as described at https://errorprone.info/docs/installation#maven. The warnings can be addressed using the @SuppressWarnings annotation, or have entire classes of warnings turned off.

This will improve code quality and reduce drift with Google's monorepo. This will also enable other interesting features, such as using @CompileTimeConstant on some of the parameters of the statement sql builder, to encouraging parameterised queries to lower the risk of introducing SQL injection vulnerabilities.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jan 30, 2025
@schcamille schcamille linked a pull request Jan 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the googleapis/java-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: add Error Prone and suppress existing errors schcamille/java-spanner
2 participants
@rahul2393 @schcamille