Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update SpannerSample.java to align with best practices #3623

Open
adhiggs opened this issue Feb 1, 2025 · 0 comments · May be fixed by #3625
Open

docs: Update SpannerSample.java to align with best practices #3623

adhiggs opened this issue Feb 1, 2025 · 0 comments · May be fixed by #3625
Assignees
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples.

Comments

@adhiggs
Copy link

adhiggs commented Feb 1, 2025

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Please run down the following list and make sure you've tried the usual "quick fixes":

If you are still having issues, please include as much information as possible:

static void readOnlyTransaction in the sample uses a try-with-resources statement in the second statement, but not the first statement. The associated pull request adds a try-with-resources statement to the first statement to make it compliant with best practices.

For more information, see b/372711568.

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Feb 1, 2025
@adhiggs adhiggs changed the title Update sample to use try-with-resources as a best practice fix:Update SpannerSample.java to align with best practices Feb 1, 2025
@adhiggs adhiggs changed the title fix:Update SpannerSample.java to align with best practices docs: Update SpannerSample.java to align with best practices Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants