Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add high performance, correct font compiler requirements document #19

Open
chrissimpkins opened this issue May 16, 2022 · 4 comments · May be fixed by #22
Open

Add high performance, correct font compiler requirements document #19

chrissimpkins opened this issue May 16, 2022 · 4 comments · May be fixed by #22

Comments

@chrissimpkins
Copy link
Member

chrissimpkins commented May 16, 2022 •
edited
Loading

Add a Markdown document that outlines what the requirements for a high performance, correct compiler are, why, and what the impact of having or not having a fast compiler are as a starting point.

Address the following in the document:

  • does it need to be developed in Rust?
  • does it need to be developed as a new compiler from scratch, rather than an incremental transition of the existing Py compiler pipeline? If incremental vs from scratch is believed to be key this should be explicit in the document
  • speak to how much impact for how much faster. Whats the smallest speedup that has value and when does the value of speedup diminish in value? - for example, perhaps a 10% speedup doesn't help much, 2x would be very nice, 10x might be about where the value peaks (then we dont' take a coffee break every compile), and maybe 100x is sort of nice but doesnt' matter, 10x was good enough.
  • when do we need it?
@chrissimpkins chrissimpkins changed the title Add Rust font compiler implementation strategy document Add Rust font compiler requirements document May 16, 2022
@rsheeter
Copy link
Contributor

"does it need to be developed in Rust?" - I would actually specifically NOT address this or any specific solution.

I suggest initially just focus on what we need (a faster compiler), why (impact of not having it or of having various levels of speedup), and what the current situation is (current toolchain, key limitations, etc). Also perhaps when we need it, or what the impact of having it when would be.

@chrissimpkins chrissimpkins changed the title Add Rust font compiler requirements document Add high performance, correct font compiler requirements document May 16, 2022
@dfrg
Copy link
Member

dfrg commented May 16, 2022

In addition to these broad requirements, it might be worth adding some concrete detail on the shapes of the desired inputs to the compiler and how these might diverge for subsetting. The focus thus far has been on raw serialization and my suspicion is that such a thing may not be desirable and makes it difficult to nail down a useful API.

@rsheeter
Copy link
Contributor

@simoncozens provided https://docs.google.com/document/d/1vE91ZyYtJvwYYWCQYrNgB6Zyv7dgHJ0oW5sNIZWqInE/edit as a reference. It suggests a one to two order speedup but doesn't speak to how much speedup is actually needed or why.

@chrissimpkins chrissimpkins linked a pull request May 27, 2022 that will close this issue
Draft
@chrissimpkins
Copy link
Member Author

#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compiler requirements googlefonts/oxidize
3 participants
@dfrg @chrissimpkins @rsheeter