Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: BottomSheetScrollView makes BottomSheet to expand over last snap point since v5 #2135

Closed
stefanpejak opened this issue Jan 27, 2025 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@stefanpejak
Copy link

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

Android, iOS

What happened?

Since v5, when using BottomSheetScrollView inside BottomSheet component, if content inside it is taking more spaces then device screen height, it will expand bottom sheet over last snap point. In earlier versions, for example 4.6.1 that wasn't case. It would stop at last snap point end pulling it up will scroll content, like expected. Is there some additional prop that I'm missing?

Reproduction steps

  • use bottom sheet component
  • put some snap points (['8%', '80%']
  • add bottom sheet scroll view as it's children
  • add lots of content inside scroll view
  • expand bottom sheet and see if bottom sheet stops at last snap point or it goes at the end of the device screen

Reproduction sample

/

Relevant log output

// using latest v5 version
import { View } from 'react-native;
import BottomSheet from '@gorhom/bottom-sheet';
import { BottomSheetScrollView, BottomSheetScrollViewMethods } from '@gorhom/bottom-sheet';

<BottomSheet {...props}>
  <BottomSheetScrollView {...props}>
    <View>....</View>
  </BottomSheetScrollView>
</BottomSheet>
@stefanpejak stefanpejak added the bug Something isn't working label Jan 27, 2025
Copy link

Hello @stefanpejak 👋, this issue is being automatically closed and locked because it does not follow the issue template.

@github-actions github-actions bot added the invalid This doesn't seem right label Jan 27, 2025
@github-actions github-actions bot locked as spam and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant