Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Beyla to receiver a logger object #1057

Open
marctc opened this issue Jul 25, 2024 · 1 comment
Open

Allow Beyla to receiver a logger object #1057

marctc opened this issue Jul 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@marctc
Copy link
Contributor

marctc commented Jul 25, 2024

Currently Beyla uses its own logger and it's global to all packages. This is fine using
Beyla as standalone process, but when using Beyla with Alloy the loggers are not the
same and log level can't be propagated properly.

Currently we are using slog.SetDefault to specify the log level and other options.
Ideally Beyla should receive a logger object an propagate to the rest of packages.
Usually Prometheus packages use go-kit logger, but I assume we can do the same
with slog.

@marctc marctc added the enhancement New feature or request label Jul 25, 2024
@mariomac
Copy link
Contributor

I think this fixes this task, at least partially: #1069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants