-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up after merging webcrypto & making module globally avaliable #4278
Conversation
da384c8
to
3ab8eed
Compare
@joanlopez for the record, I've just did rebase and also adjusted texting on when the experimental import will be removed |
Sorry for the slow reply, but didn't have time before to finish my proof of concept for k6/timers not being done in the same way. I did also technically went for a different way of implementing #4563 originally, but ended up being so convoluted that it made no sense. And in practice the only reason why it needed some of the stuff is so that Arguably all that to say @olegbespalov please look at #4563 and let see if we agree on the approach of moving to |
b6f9c66
to
6a8097d
Compare
What?
This PR does clean-ups after merge of module and also makes crypto (and other methods) globally available
Why?
This finalizes graduation of the web crypto
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
#4188
Closes: #3154
Closes: #4031