Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Invalid ClusterRoleBinding in provisioner #16330

Open
ryandub opened this issue Feb 17, 2025 · 0 comments
Open

Helm: Invalid ClusterRoleBinding in provisioner #16330

ryandub opened this issue Feb 17, 2025 · 0 comments

Comments

@ryandub
Copy link

ryandub commented Feb 17, 2025

Describe the bug
The logic introduced to the helm chart in #16091 causes an error when using non-namespaced RBAC. This logic appears to intend to switch between RoleBinding and ClusterRoleBinding, but instead switches between RoleBinding and ClusterBinding which is not valid. This leads to an error on chart deployment - ClusterBinding.rbac.authorization.k8s.io "" not found. The logic should be:

{{ if not .Values.rbac.namespaced }}ClusterRole{{ else }}Role{{ end }}Binding

To Reproduce
Steps to reproduce the behavior:

  1. Deploy Loki with Helm chart version >= 6.13.0

Expected behavior
If namespaced RBAC is not enabled, the deployment should properly create a ClusterRoleBinding.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: helm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant