Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Issues with mixin #3880

Closed
snuggie12 opened this issue Jul 18, 2024 · 3 comments · Fixed by #4757
Closed

Misc Issues with mixin #3880

snuggie12 opened this issue Jul 18, 2024 · 3 comments · Fixed by #4757
Assignees
Labels
help wanted Extra attention is needed keepalive Label to exempt Issues / PRs from stale workflow operations/jsonnet type/bug Something isn't working

Comments

@snuggie12
Copy link

Describe the bug
Found some misc issues with the tempo-mixin:

  • TempoBlockListRisingQuickly uses = but supplies a regex for the value (.*)
  • tempo_ingester_replay_errors_total doesn't seem to exist
  • tempodb_blocklist_poll_errors_total doesn't seem to exist
  • TempoDistributorUnhealthy possibly points at a bad ring name? I'm not sure if other installs have a distributor ring, but it does make sense to me that ingester would have a ring so I think this is a mistake?

Environment:

  • Infrastructure: kubernetes
  • Deployment tool: helm (tempo-distributed) plus kustomize to apply what's in tempo-mixin-compiled
@joe-elliott
Copy link
Member

joe-elliott commented Jul 18, 2024

Our jsonnet is likely quite out of date. We still vendor and use it internally, but we've likely bandaided over all of these small details over time.

Thanks for the report.

@joe-elliott joe-elliott added type/bug Something isn't working operations/jsonnet labels Jul 18, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Sep 17, 2024
@joe-elliott joe-elliott added help wanted Extra attention is needed keepalive Label to exempt Issues / PRs from stale workflow and removed stale Used for stale issues / PRs labels Sep 17, 2024
@ruslan-mikhailov ruslan-mikhailov self-assigned this Feb 25, 2025
@ruslan-mikhailov
Copy link
Contributor

Hello!

tempo_ingester_replay_errors_total is defined here: https://github.com/grafana/tempo/blob/main/modules/ingester/instance.go#L73 and tempodb_blocklist_poll_errors_total is defined here: https://github.com/grafana/tempo/blob/main/tempodb/blocklist/poller.go#L46. The absence of these metrics likely means that there have been no such errors in the past.

We will fix the remaining issues. Thank you for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed keepalive Label to exempt Issues / PRs from stale workflow operations/jsonnet type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants