Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which graphiql version is using? #85

Open
qinst64 opened this issue Nov 16, 2020 · 2 comments
Open

which graphiql version is using? #85

qinst64 opened this issue Nov 16, 2020 · 2 comments

Comments

@qinst64
Copy link

qinst64 commented Nov 16, 2020

I have Flask-GraphQL==2.0.1 installed and inside Chrome it is requiring dependencies like

http://cdn.jsdelivr.net/npm/[email protected]/graphiql.min.js
note: currently the latest version in jsdelivr is 1.0.6

however the github readme says

graphiql_version: The graphiql version to load. Defaults to "1.0.3".

reallly? If I set graphiql_version=1.0.3 explicitly, then Chrome throws error

Uncaught Error: GraphiQL 0.18.0 and after is not compatible with React 15 or below

I did not find anywhere the render_graphiql.py set the variable to "1.0.3"
In my local drive is GRAPHIQL_VERSION = '0.11.11';
and gitlab GRAPHIQL_VERSION = '0.7.1'

@multimeric
Copy link

It's because you are reading the readme for the master branch, but that is somewhat newer than the latest PyPI release, which is v2.0.1. This version used a much older version of React and a much older default GraphiQL. You can in theory upgrade a few of these packages to the github master branch but I don't recommend it for dependency hell reasons. I think we just have to wait until this repo, and graphql-server publish their 3.x.x versions and everything will work.

@multimeric
Copy link

The best we can do using stable versions is graphiql_version="0.17.5". Newer versions aren't supported because of the old React version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants