Forbid @skip and @include directives in subscription root selection #3974
+128
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
benjie
added
the
spec RFC
|
GraphQL v17 would be a good time to add this "breaking change" @graphql/graphql-js-reviewers |
saihaj
approved these changes
Nov 13, 2023
benjie
force-pushed
the
forbid-skip-include-on-subscription
branch
from
2ffbde6 to
93f71d8
Compare
benjie
force-pushed
the
forbid-skip-include-on-subscription
branch
from
3d0f625 to
794e73a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of graphql/graphql-spec#860
The spec calls for a separate
CollectSubscriptionFieldsalgorithm due to executing withoutvariableValues; but I figured that maintenance would be easier with the algorithms synchronized.Please feel free to make any changes you need to this PR; it's just to get the ball rolling.
Related GraphQL WG action item (from 2021!): graphql/graphql-wg#695