From 94f55b9bcab6cdb0f8802300aa84a1a4058fa08b Mon Sep 17 00:00:00 2001 From: Andreas Marek Date: Tue, 25 Feb 2025 06:33:59 +1000 Subject: [PATCH 1/2] Clarify pair members are distinct --- spec/Section 5 -- Validation.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/Section 5 -- Validation.md b/spec/Section 5 -- Validation.md index 75af96ffd..578f09489 100644 --- a/spec/Section 5 -- Validation.md +++ b/spec/Section 5 -- Validation.md @@ -420,7 +420,7 @@ FieldsInSetCanMerge(set): - Let {fieldsForName} be the set of selections with a given response name in {set} including visiting fragments and inline fragments. -- Given each pair of members {fieldA} and {fieldB} in {fieldsForName}: +- Given each pair of distinct members {fieldA} and {fieldB} in {fieldsForName}: - {SameResponseShape(fieldA, fieldB)} must be true. - If the parent types of {fieldA} and {fieldB} are equal or if either is not an Object Type: @@ -452,7 +452,7 @@ SameResponseShape(fieldA, fieldB): selection set of {fieldB}. - Let {fieldsForName} be the set of selections with a given response name in {mergedSet} including visiting fragments and inline fragments. -- Given each pair of members {subfieldA} and {subfieldB} in {fieldsForName}: +- Given each pair of distinct members {subfieldA} and {subfieldB} in {fieldsForName}: - If {SameResponseShape(subfieldA, subfieldB)} is {false}, return {false}. - Return {true}. From 2b395c4be7a21c85ae0c4782839ec09549b36ac4 Mon Sep 17 00:00:00 2001 From: Andreas Marek Date: Tue, 25 Feb 2025 09:07:10 +1000 Subject: [PATCH 2/2] fix formatting --- spec/Section 5 -- Validation.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spec/Section 5 -- Validation.md b/spec/Section 5 -- Validation.md index 578f09489..44bc9dbba 100644 --- a/spec/Section 5 -- Validation.md +++ b/spec/Section 5 -- Validation.md @@ -452,7 +452,8 @@ SameResponseShape(fieldA, fieldB): selection set of {fieldB}. - Let {fieldsForName} be the set of selections with a given response name in {mergedSet} including visiting fragments and inline fragments. -- Given each pair of distinct members {subfieldA} and {subfieldB} in {fieldsForName}: +- Given each pair of distinct members {subfieldA} and {subfieldB} in + {fieldsForName}: - If {SameResponseShape(subfieldA, subfieldB)} is {false}, return {false}. - Return {true}.