Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buddy] Add saml_idp_service_provider resource support to the terraform provider #51868

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Feb 5, 2025

Buddy PR for #51586


Fixes #41874 adding a terraform resource and data source for saml_idp_service_provider

Changelog: Add support for saml_idp_service_provider objects in Terraform module.

@public-teleport-github-review-bot

@tigrato - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

Copy link

github-actions bot commented Feb 5, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
tigrato/pr-buddy-51586 2df247d 4 ✅SUCCEED tigrato-pr-buddy-51586 2025-02-06 11:18:38

@hugoShaka
Copy link
Contributor

I think @flyinghermit wanted to do a few checks and observe computed fields. Have you got a chance to do them?

@flyinghermit
Copy link
Contributor

flyinghermit commented Feb 7, 2025

Sorry I haven't been able to get to this yet. I will try to get to the review early next week.

The gist is, there are guided and generic SAML service provider configuration. Guided ones are what we call "preset" ones. For both generic and preset types, entity_descriptor is a computed field but we only auto-generate it if its empty. And for the preset types, the relay_state, attribute_mapping and entity_descriptor fields are the computed fields. Since the terraform provider for the saml_idp_service_provider has been of interest for many Teleport users, I just want to ensure what initially works and what does not so the limitations are communicated upfront.

This ticket elaborates more on the issue and is a precursor to support both the generic and preset SAML service provider in terraform #43431.

Edit: Many thanks @dangorst1066 for initiating this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the saml_idp_service_provider resource kind in the Terraform provider
4 participants