Replies: 10 comments 30 replies
-
What that ties all of the code in this repo together is that it will be run by a JavaScript runtime, whether in a client or server. It can be confusing that the code itself is written in TypeScript… |
Beta Was this translation helpful? Give feedback.
-
given @jamesmockett's excellent counter argument to I'm generally not in favour of this - it feels like you're not dealing with the fact that you don't understand what you're proposing. is that the case here? should we be able to describe what this repo does? or is it actually quite nebulous, in a good way? |
Beta Was this translation helpful? Give feedback.
-
I don't think 'client-side' necessarily excludes server-side code if we think of 'client-side' work as fullstack. So it describes an orientation rather than a hard architectural boundary. |
Beta Was this translation helpful? Give feedback.
-
Throwing some more out there:
Naming is hard. |
Beta Was this translation helpful? Give feedback.
-
how about |
Beta Was this translation helpful? Give feedback.
-
My suggestion would be to name it what it is for future folk to be able to guess what it does. My next question then is, what is this repo intended for? (see edit of comment if you want to see me publicly thinking aloud on this) |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
I think the issue is that the packages contained in the monorepo are so broad. It currently contains packages that
That makes it hard to come up with a name thats descriptive enough as to what they all do, without it being too limiting in the future as to what we can include. So I have a fairly generic suggestion (maybe too generic) of |
Beta Was this translation helpful? Give feedback.
-
Loads of different and interesting ideas in here so far - but I think the conversation has been quite focussed on what goes in the monorepo, instead of why it goes into the monorepo, therefor I'd like to start the discussion on the idea that a monorepo is usually a series of libs & apps that all depend on each other in various ways - the best reason to put your new lib in CSNX is because if it's using CSNX code, it's just easier. So, names that are around inter-dependency, linking & sharing seem like the way to go in my opinion (if it's not
Okay so I admit ... I don't actually have any good name ideas for this theme, but I do like the idea of the name being themed around the idea that things go in this repo because they're all sharing with each other, relying on each other, etc. |
Beta Was this translation helpful? Give feedback.
-
Thinking of more journalistic related terms similar to
|
Beta Was this translation helpful? Give feedback.
-
csnx
is an awkward acronym of client side Nx. It has (at least) two big problems:You have to call a repo something and it seemed the least worst option at the time, but now we're considering publishing everything in
/libs
as one mega-package, the problem is back.A package called
@guardian/csnx
makes a lot of sense, in that it's clear where the code lives, why a feature is included in the package (it's in the repo) and adoption paves the way to moving codebases into the monorepo.But it's an awful name, for the same reasons above (except it's not even Nx once it's published).
So let's find something better.
Beta Was this translation helpful? Give feedback.
All reactions