Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Things to improve in the bank verifier #4931

Open
titodalcanton opened this issue Nov 9, 2024 · 0 comments
Open

Things to improve in the bank verifier #4931

titodalcanton opened this issue Nov 9, 2024 · 0 comments
Labels
enhancement

Comments

@titodalcanton
Copy link
Contributor

Here are a few notes I had lying around from the last time I used the bank verifier.

  • pycbc_banksim cannot use an HDF injection file, so we are stuck with splitting injections to XML files.
  • If I remove the point injections, some plotting jobs still try to run on those results and fail. The workflow should just not plan those jobs instead.
  • When a waveform generation fails, pycbc_banksim should log its parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@titodalcanton