Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Update Dialog component #241

Closed
4 tasks
Aveline-art opened this issue May 7, 2022 · 1 comment
Closed
4 tasks

Accessibility: Update Dialog component #241

Aveline-art opened this issue May 7, 2022 · 1 comment
Labels
feature: Design System PBV: dev all issues for engineering roles (devops, backend, frontend, db) role: frontend Pertains to frontend tasks size: 3pt Can be done in 13-18 hours
Milestone
07 - MVP 1

Comments

@Aveline-art
Copy link
Member

Aveline-art commented May 7, 2022 •
edited
Loading

Overview

As a developer, we need to make sure that our components are accessible as much as humanly possible. For this issue we will update our Dialog component for accessibility.

Action Items

  • Read the accessibility guidelines for dialogs
  • Edit the dialog until it is accessible based on the guidelines
    • One guideline that needs to be updated is to have the modal exit when certain keys are pressed
    • Another is to keep the tab within the dialog

Resources/Instructions

Resources
WAI-ARIA Authoring Practices 1.1
@Aveline-art Aveline-art added p-feature: Components role: frontend Pertains to frontend tasks size: 3pt Can be done in 13-18 hours ready for milestone size: 2pt Can be done in 7-12 hours and removed size: 3pt Can be done in 13-18 hours size: 2pt Can be done in 7-12 hours labels May 7, 2022
@sdimran sdimran added this to the 07 - MVP 1 milestone May 10, 2022
@ExperimentsInHonesty ExperimentsInHonesty added the PBV: dev all issues for engineering roles (devops, backend, frontend, db) label Jun 12, 2024
@nooriaali9
Copy link
Member

Closing this issue - since it is outdated/ not a priority anymore - based off of #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: Design System PBV: dev all issues for engineering roles (devops, backend, frontend, db) role: frontend Pertains to frontend tasks size: 3pt Can be done in 13-18 hours
Projects
P: CTJ: Project Board
Archived in project
Milestone
07 - MVP 1
Development

No branches or pull requests
6 participants
@sdimran @nooriaali9 @ExperimentsInHonesty @Aveline-art @jenchuu @luca-navarrete