Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve Material UI errors #1546

Closed
16 tasks
Tracked by #1545
sydneywalcoff opened this issue Sep 9, 2024 · 3 comments
Closed
16 tasks
Tracked by #1545

resolve Material UI errors #1546

sydneywalcoff opened this issue Sep 9, 2024 · 3 comments
Assignees
Labels
feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: high role: development anything related to code size: 2pt Can be done in 7-12 hours Status: Update Requested

Comments

@sydneywalcoff
Copy link
Member

sydneywalcoff commented Sep 9, 2024

Overview

Since Github changed the Node version they use to run Github actions from Node18 to Node20, we're getting some warnings and errors across the app.

It looks like Material UI has deprecated 'globals'.

Action Items

  • make sure you are running Node v20.16
  • identify the cause of the error
  • resolve error
  • test against live site to make sure styles are still correctly applied
    • landing page
    • FAQs
    • 404
    • About Us
    • Credits
    • Privacy Policy
    • Terms of Use
    • The Letter Generator
      • Welcome
      • Before you Begin
      • Advice
      • The LG (these all use the same layout)

Resources/Notes

@sydneywalcoff sydneywalcoff added feature: technical standards accessibility, usability, unit testing, etc. role: development anything related to code priority: high size: 2pt Can be done in 7-12 hours front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person labels Sep 9, 2024
@sydneywalcoff sydneywalcoff added this to the Stakeholder Review 2.0 milestone Sep 9, 2024
@sydneywalcoff sydneywalcoff added draft Not yet ready to be worked on and removed draft Not yet ready to be worked on labels Sep 9, 2024
@eburdekin eburdekin self-assigned this Sep 17, 2024
Copy link

Hey @eburdekin! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

Copy link

Hey @eburdekin! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@eburdekin
Copy link
Member

@sydneywalcoff noting here too - for this error we're seeing on the routing tests PR #1466

Screenshot 2024-09-23 at 7 01 43 PM

we can resolve by updating customMuiTheme.ts from this:
Screen Shot 2024-09-29 at 5 03 47 PM
to this:
Screen Shot 2024-09-29 at 5 03 28 PM

that's already the case on dev so I'll close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: high role: development anything related to code size: 2pt Can be done in 7-12 hours Status: Update Requested
Projects
Development

No branches or pull requests

2 participants