Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Github Action to verify Pull Requests are created by website team members #3906

Closed
3 tasks done
MattPereira opened this issue Jan 31, 2023 · 34 comments · Fixed by #6971
Closed
3 tasks done

Create a Github Action to verify Pull Requests are created by website team members #3906

MattPereira opened this issue Jan 31, 2023 · 34 comments · Fixed by #6971
Assignees
@ajb176
Labels
automation for manulal github board maintenance actions that are going to be automated Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours
Milestone
08. Team workflow

Comments

@MattPereira
Copy link
Contributor

MattPereira commented Jan 31, 2023 •
edited by ajb176
Loading

Overview

As developers, we need to ensure that only members of our organization create pull requests to the hackforla / website repository. For this issue, we will add a github action that checks if the pull request creator is a member of the website team.

Action Items

  • Learn how github actions work
  • Add a github action that checks if the creator of a pull request is a member of the website-write team
    • If the author is not a member of the website-write team, close the pull request with this comment:
You must be a member of the HFLA  website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started.  If you have been though onboarding, and feel this message in error, please message us in the #hfla-site team slack channel with the link to this PR.

Resources/Instructions
@MattPereira MattPereira added role: back end/devOps Tasks for back-end developers Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly automation for manulal github board maintenance actions that are going to be automated size: 3pt Can be done in 13-18 hours Draft Issue is still in the process of being created labels Jan 31, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 08. Team workflow milestone Mar 5, 2023
@KazushiR KazushiR self-assigned this Apr 5, 2023
@github-actions

This comment has been minimized.

Sign in to view
@KazushiR

This comment was marked as outdated.

Sign in to view
@KazushiR

This comment was marked as outdated.

Sign in to view
@KazushiR KazushiR removed their assignment Apr 14, 2023
@roslynwythe

This comment was marked as resolved.

Sign in to view
@ExperimentsInHonesty

This comment was marked as resolved.

Sign in to view
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Nov 6, 2023
@ExperimentsInHonesty ExperimentsInHonesty mentioned this issue Nov 6, 2023
Open
2 tasks
@roslynwythe

This comment was marked as resolved.

Sign in to view
@roslynwythe roslynwythe added ready for product and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Nov 13, 2023
@ExperimentsInHonesty

This comment was marked as resolved.

Sign in to view
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Nov 14, 2023
@roslynwythe

This comment was marked as resolved.

Sign in to view
@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Dec 10, 2023
@roslynwythe roslynwythe added ready for product and removed Draft Issue is still in the process of being created labels Dec 18, 2023
@ExperimentsInHonesty ExperimentsInHonesty mentioned this issue Jan 3, 2024
Open
5 tasks
@ExperimentsInHonesty
Copy link
Member

@roslynwythe I have created an ER to address the remaining items on this issue (adding it to the pr template)

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@LRenDO

This comment was marked as outdated.

Sign in to view
@LRenDO LRenDO removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label May 1, 2024
@ajb176 ajb176 self-assigned this May 4, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ajb176
Copy link
Member

ajb176 commented May 4, 2024

ETA: 3 weeks
Availability: Evenings

@github-actions github-actions bot added the To Update ! No update has been provided label May 17, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ajb176
Copy link
Member

ajb176 commented May 17, 2024

  1. Have a rough idea of what the implementation needs to look like, still need to set up the testing environment and take a few hours to go through the Github API docs.
  2. Nothing yet, will update this if necessary over the next two days
  3. Will have a lot of time this weekend
  4. Hope to finish by the end of this weekend if there are no blockers, latest by next weekend.

@ajb176 ajb176 added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels May 17, 2024
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label May 24, 2024
@ajb176 ajb176 mentioned this issue May 24, 2024
Merged
@ajb176
Copy link
Member

ajb176 commented May 27, 2024

Progress: The control flow for verifying team membership seems like it's working properly, still need to test the API call that closes the PR.
Blockers: None, but testing is time consuming
Availability: Tuesday evening
ETA: Sunday, if not done by Wednesday

@ajb176 ajb176 added the Status: Updated No blockers and update is ready for review label May 27, 2024
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label May 31, 2024
@ajb176
Copy link
Member

ajb176 commented Jun 2, 2024

Code is done but due to a personal emergency I most likely won't be able to draft a PR for a few days

@ajb176 ajb176 added the Status: Updated No blockers and update is ready for review label Jun 2, 2024
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Merged
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Jun 7, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board label Jun 18, 2024
@ajb176 ajb176 mentioned this issue Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajb176 ajb176

Labels
automation for manulal github board maintenance actions that are going to be automated Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours
Projects
P: HfLA Website: Project Board
Status: Done
Milestone
08. Team workflow
7 participants
@roslynwythe @ajb176 @ExperimentsInHonesty @KazushiR @roychan1 @LRenDO @MattPereira