Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched length between sequential visualization colors and colorRange prop for Deck.gl map layer components #1152

Open
3 tasks
jaronheard opened this issue Nov 22, 2019 · 0 comments

Comments

@jaronheard
Copy link
Contributor

Description

Some Deck.gl layers expect a colorRange array of 6 colors, but the sequential visualization colors arrays in our theme have 9 colors.

As noted by @mendozaline here, this affects the ScreenGridMap component, but may impact other map components:

  1. The colorRange prop should only take an array of 6 colors, according to the deck.gl documentation.
  • I think this is why the map doesn't display all 9 colors from the CIVIC thermal color scheme. It may be only using the first six colors in the array. This could be why the map appears so light

Definition of done

  • Components in component-library using Deck.gl layers with colorRange prop have an array length added to their PropTypes
  • Sequential visualization color arrays are available in VisualizationColors.js for each length of colorRange needed for Deck.gl layers
  • Usage of sequential visualization color arrays in other packages (e.g. Sandbox) adjusted to use sequential color arrays

One elegant way would be to provide a function for each sequential visualization color that takes a length and returns an array of the proper length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant