Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the PATCH function fails, haikuporter resets to ORIGIN, removing patchset commits #284

Open
jmairboeck opened this issue Mar 24, 2024 · 0 comments

Comments

@jmairboeck
Copy link
Member

I noticed this when updating texlive_core, which uses both a patchset and a PATCH function. The PATCH function failed (because it needs autoconf 2.72 apparently) and HaikuPorter resetted the internal git repo back to ORIGIN, effectively discarding the patchset commits. The flag.patchset file was not deleted, however, so that results in an inconsistent state.

Do we need a new tag that is applied after the patchset and reset to that instead if it is present, or could we just reset to HEAD instead when the PATCH function fails? If the resetting to ORIGIN is retained, at least the flag.patchset should be removed in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant