Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: closed range streaming #633

Merged
merged 1 commit into from
Feb 14, 2025
Merged

feat: closed range streaming #633

merged 1 commit into from
Feb 14, 2025

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Feb 10, 2025 •
edited
Loading

Reviewer Notes

  • Added support for closed-range historic block streaming as specified in the design doc
  • Modified Simulator code with an additional streaming method based on config values
  • Added range validation checks in PbjBlockStreamServiceProxy
  • Modified the consumer.sh to pass the smoke tests after the changes.
  • Added dashboard row to count historic blocks sent
  • Added debug logging for troubleshooting
  • Added additional liveness, readiness check if the smoke tests fail for debugging CI issues

Related Issue(s)

@mattp-swirldslabs mattp-swirldslabs added Block Node Issues/PR related to the Block Node. Alpha-0 Issues related to features designated for the Alpha-0 release labels Feb 10, 2025
@mattp-swirldslabs mattp-swirldslabs added this to the 0.5.0 milestone Feb 10, 2025
@mattp-swirldslabs mattp-swirldslabs self-assigned this Feb 10, 2025
ata-nas
ata-nas reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks good on first glance. I leave some initial comments, also I would personally never use var, I understand that may be more of a "code style" remark, but it is really hard to determine what the type is supposed to be.

server/src/main/java/com/hedera/block/server/consumer/HistoricBlockStreamSupplier.java Outdated Show resolved Hide resolved
server/src/main/java/com/hedera/block/server/consumer/HistoricBlockStreamSupplier.java Outdated Show resolved Hide resolved
server/src/main/java/com/hedera/block/server/consumer/HistoricBlockStreamSupplier.java Outdated Show resolved Hide resolved
server/src/test/java/com/hedera/block/server/pbj/PbjBlockStreamServiceProxyTest.java Outdated Show resolved Hide resolved
server/src/test/java/com/hedera/block/server/util/PersistTestUtils.java Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/grpc/impl/ConsumerStreamGrpcClientImpl.java Outdated Show resolved Hide resolved
server/src/test/java/com/hedera/block/server/consumer/HistoricBlockStreamSupplierTest.java Outdated Show resolved Hide resolved
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00581-closed-range-streaming branch 3 times, most recently from 5923d9d to 8328c95 Compare February 11, 2025 23:45
@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review February 12, 2025 00:13
@mattp-swirldslabs mattp-swirldslabs requested a review from a team as a code owner February 12, 2025 00:13
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00581-closed-range-streaming branch 2 times, most recently from b6b183c to 0e6bff6 Compare February 13, 2025 21:47
AlfredoG87
AlfredoG87 previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good! 💯
just 1 nit.

server/src/main/java/com/hedera/block/server/config/ServerMappedConfigSourceInitializer.java Show resolved Hide resolved
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00581-closed-range-streaming branch 2 times, most recently from bdbc477 to fef13ef Compare February 14, 2025 17:29
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00581-closed-range-streaming branch from fef13ef to e8f7bbf Compare February 14, 2025 19:44
AlfredoG87
AlfredoG87 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattp-swirldslabs mattp-swirldslabs merged commit cbd61b9 into main Feb 14, 2025
18 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00581-closed-range-streaming branch February 14, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbair23 rbair23 rbair23 left review comments

@ata-nas ata-nas ata-nas left review comments

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

Assignees

@mattp-swirldslabs mattp-swirldslabs

Labels
Alpha-0 Issues related to features designated for the Alpha-0 release Block Node Issues/PR related to the Block Node.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Unit test closed-range historic streaming Implement closed-range historic streaming
4 participants
@mattp-swirldslabs @rbair23 @ata-nas @AlfredoG87