fix: ackHandler order responses under edge cases #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredoG87
added
Block Node
ata-nas
reviewed
Feb 13, 2025
server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java
Outdated
Show resolved
Hide resolved
mattp-swirldslabs
previously approved these changes
Feb 13, 2025
Nana-EC
reviewed
Feb 14, 2025
server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java
Outdated
Show resolved
Hide resolved
…ner and in the UTs. With these fixes we aim at fix them Signed-off-by: Alfredo Gutierrez <[email protected]>
… with random delays and with no delays. Signed-off-by: Alfredo Gutierrez <[email protected]>
…xt block as the last thing in the if block Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
fix-ack-logic
branch
from
87c6f46 to
320503a
Compare
Signed-off-by: Alfredo Gutierrez <[email protected]>
mattp-swirldslabs
approved these changes
Feb 14, 2025
Nana-EC
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
This PR adds test that helped replicate edge cases when acks were sent out of order.
either due to the workaround to determine the first valid block (where to start sending acks) or
due to random delays occur in either
persistenceorverificationthreads.Also this PR includes the fixes so those tests always pass instead of always failing or sometimes failing.
Fixes #638
Before:
After: Under the same conditions, same result in multiple passes.
Related Issue(s)