Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method isAssociated should revert for non-existing accounts #242

Open
arianejasuwienas opened this issue Feb 14, 2025 · 0 comments · May be fixed by #243
Open

Method isAssociated should revert for non-existing accounts #242

arianejasuwienas opened this issue Feb 14, 2025 · 0 comments · May be fixed by #243
Assignees
@arianejasuwienas
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@arianejasuwienas
Copy link
Contributor

arianejasuwienas commented Feb 14, 2025 •
edited
Loading

Description

Our current implementation of the isAssociated method returns false when querying for a non-existent account. This behavior differs from that of the real, non-emulated HTS, where revert is performed in tis scenario.

Steps to reproduce

This can be observed when running the:

should get not `isAssociated` for non-existing non-associated accounts

test from the hts.e2e test set.

Additional context

No response

Hedera network

No response

Version

v0.1.1

Operating system

None
@arianejasuwienas arianejasuwienas added the bug A error that causes the feature to behave differently than what was expected based on design docs label Feb 14, 2025
@arianejasuwienas arianejasuwienas self-assigned this Feb 14, 2025
@arianejasuwienas arianejasuwienas moved this from Backlog to Tasks In Progress in Smart Contract Sprint Board Feb 14, 2025
@arianejasuwienas arianejasuwienas changed the title hts.isAssociated should return false for non-existing accounts Method isAssociated should return false for non-existing accounts Feb 14, 2025
@arianejasuwienas arianejasuwienas changed the title Method isAssociated should return false for non-existing accounts Method isAssociated should return false for non-existing accounts Feb 14, 2025
@arianejasuwienas arianejasuwienas changed the title Method isAssociated should return false for non-existing accounts Method isAssociated should return revert for non-existing accounts Feb 14, 2025
arianejasuwienas added a commit that referenced this issue Feb 14, 2025
@arianejasuwienas
fix: isassociated method will revert for non-existing accounts (#242)
f555c03 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@arianejasuwienas arianejasuwienas linked a pull request Feb 14, 2025 that will close this issue
fix: isassociated method will revert for non-existing accounts (#242) #243
Draft
2 tasks
@arianejasuwienas arianejasuwienas linked a pull request Feb 14, 2025 that will close this issue
Draft
2 tasks
@arianejasuwienas arianejasuwienas changed the title Method isAssociated should return revert for non-existing accounts Method isAssociated should revert for non-existing accounts Feb 14, 2025
arianejasuwienas added a commit that referenced this issue Feb 14, 2025
@arianejasuwienas
fix: isassociated method will revert for non-existing accounts (#242)
4d3558f 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@acuarica acuarica added feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. and removed bug A error that causes the feature to behave differently than what was expected based on design docs labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arianejasuwienas arianejasuwienas

Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Smart Contract Sprint Board
Status: Tasks In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: isassociated method will revert for non-existing accounts (#242) hashgraph/hedera-forking
2 participants
@acuarica @arianejasuwienas