Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay White Noise Error] Improve Request Validation to Prevent Invalid eth_call Consensus Node Retries #3443

Open
quiet-node opened this issue Feb 3, 2025 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@quiet-node
Copy link
Member

Problem

Some eth_call requests return 501 Not Implemented from the Mirror Node because the Mirror Node does not support certain methods that the Consensus Node does. However, the Relay currently retries these requests with the Consensus Node, and if the request is truly invalid, it results in a 500 error instead of correctly passing the 501 error to the client.

This behavior causes:

  • Misleading error responses, as clients receive a generic 500 Internal Server Error instead of the accurate 501 Not Implemented when applicable.
  • Unnecessary retries for requests that the Mirror Node cannot handle but should be forwarded to the Consensus Node when valid.

Solution

  • Ensure 501 Not Implemented responses from the Mirror Node are correctly forwarded to clients when applicable, instead of being masked as 500 errors.
  • Prevent unnecessary retries for truly invalid requests.
  • Maintain correct routing behavior by forwarding valid but unsupported requests to the Consensus Node when needed.

Alternatives

No response

@quiet-node quiet-node added the enhancement New feature or request label Feb 3, 2025
@quiet-node quiet-node added this to the 0.67.0 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant