Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMALL]Automatic bumping PRs are not properly structured #3319

Open
quiet-node opened this issue Dec 9, 2024 · 0 comments · May be fixed by #3469
Open

[SMALL]Automatic bumping PRs are not properly structured #3319

quiet-node opened this issue Dec 9, 2024 · 0 comments · May be fixed by #3469
Assignees
@simzzz
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Milestone
0.67.0

Comments

@quiet-node
Copy link
Member

Problem

The hedera-json-rpc-relay utilizes automatic Snyk PRs to update dependencies alongside Dependabot. However, Snyk PRs are not well-structured, requiring significant manual effort to prepare them for review.

  • Snyk PRs lack proper conventional type prefixes in their titles (e.g., build: or build(dep):).
  • Snyk PRs are improperly signed, causing the DCO job to fail consistently.
  • Snyk PRs don't have approprate labels (e.g., dependencies)

Solution

Approve Snyk PRs to resolve the issues

Alternatives

No response
@quiet-node quiet-node added enhancement New feature or request internal For changes that affect the project's internal workings but not its outward-facing functionality. and removed enhancement New feature or request labels Dec 9, 2024
@Ferparishuertas Ferparishuertas changed the title Automatic bumping PRs are not properly structured [SMALL]Automatic bumping PRs are not properly structured Feb 5, 2025
@simzzz simzzz linked a pull request Feb 11, 2025 that will close this issue
Open
@simzzz simzzz moved this from Backlog to In Review in Smart Contract Sprint Board Feb 11, 2025
@simzzz simzzz added this to the 0.67.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simzzz simzzz

Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
Smart Contract Sprint Board
Status: In Review
Milestone
0.67.0
Development

Successfully merging a pull request may close this issue.

feat: adds proper structure to automatic bumping PRs hashgraph/hedera-json-rpc-relay
2 participants
@simzzz @quiet-node