Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Brave Wallet #809

Closed
rbair23 opened this issue Dec 18, 2023 · 2 comments
Closed

Add support for Brave Wallet #809

rbair23 opened this issue Dec 18, 2023 · 2 comments
Assignees
@ericleponner
Labels
enhancement New feature or request good first issue Good for newcomers P3 Low priority issue. Will not impact the release schedule if not complete

Comments

@rbair23
Copy link
Member

rbair23 commented Dec 18, 2023

Problem

We support MetaMask in HashScan. We can also support Brave.

Solution

Add Brave support just like meta mask.

Alternatives

No response
@rbair23 rbair23 added enhancement New feature or request good first issue Good for newcomers P3 Low priority issue. Will not impact the release schedule if not complete labels Dec 18, 2023
@ericleponner
Copy link
Collaborator

Some findings:

  • Brave Wallet is built directly in the browser
  • list of supported chains is also built-in but does not include Hedera for now
  • some discussions about adding Hedera to Brave Wallet took place a while ago
  • nothing explicitly planned for now

@svienot svienot mentioned this issue Dec 21, 2023
Closed
@ericleponner ericleponner self-assigned this Jan 8, 2024
@ericleponner
Copy link
Collaborator

This is implemented by #828.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericleponner ericleponner

Labels
enhancement New feature or request good first issue Good for newcomers P3 Low priority issue. Will not impact the release schedule if not complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbair23 @ericleponner