-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code in web3 tests #10255
Comments
This issue mentioned here SENDER_ALIAS_ SENDER_PUBLIC_KEY will be fixed in future PR |
The issue mentioned here persistFungibleToken() will be fixed in a future PR, so that the latter does not become big. |
The issue mentioned here will be addressed in a future PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
A lot of tests have similar individual setup that can be extracted in a parent class and thus making the code easier to read and maintain. Methods like persistFungibleToken and fungibleTokenPersist exist in child and parent classes that are duplicated in different suits and mistake in one needs to be corrected in all. This will remove the need to fix broken tests individually
Solution
If this can be done with 1 method that serves both purposes - best.
Alternatives
No response
The text was updated successfully, but these errors were encountered: