Added the logic to increase the response cache maxAge for /schedule/id #10383
+123
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Sawarkar <[email protected]>
steven-sheehy
added
enhancement
jnels124
requested changes
Feb 14, 2025
| const expirationTime = utils.nsToSecNs(schedule.expiration_time); | ||
| const consensusTimestamp = utils.nsToSecNs(schedule.consensus_timestamp); | ||
|
|
||
| if (schedule.deleted || (executedTimestamp && executedTimestamp !== '')) { |
There was a problem hiding this comment.
executedTimestamp is sufficient. '' is falsey
There was a problem hiding this comment.
This is a little easier to understand.
const hasExecuted = !!executedTimestamp || schedule.deleted;
const hasAutoExpired = !expirationTime && now >= consensusTimestamp + 1860;
const hasExpired = expirationTime && now >= expirationTime + 60;
const maxAge = hasExecuted || hasAutoExpired || hasExpired ? 3600 : 1;There was a problem hiding this comment.
I believe this will break other tests as not all tests should result in the longer max age. Tests that rely on the different header value will need to be grouped into the same folder with each folder having the correct responseHeaders.json.
There was a problem hiding this comment.
We should add a test case for explicitly expired and one for implicitly expired.
There was a problem hiding this comment.
can look in the specs for examples of.
"features": {
"fakeTime": "TIME_VALUE"
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Increase cache max-age to 1 hour for finalized schedules to reduce unnecessary backend queries.
Related issue(s):
Fixes #10321
Notes for reviewer:
Checklist