Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor persistNFT methods in web3 tests #10359

Open
filev94 opened this issue Feb 11, 2025 · 0 comments
Open

Refactor persistNFT methods in web3 tests #10359

filev94 opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
enhancement Type: New feature

Comments

@filev94
Copy link
Contributor

filev94 commented Feb 11, 2025

Problem

In web3 tests, there are persistNft private methods that can be extracted to the parent class AbstractContractCallServiceTest. nonFungibleTokenPersist also can be refactored just like the fungibleTokenPersist() method.

Solution

Extract persistNft private method into abstract class and modify nonFungibleTokenPersist and methods around it, similar to fungibleTokenPersist()

Alternatives

No response

@filev94 filev94 added the enhancement Type: New feature label Feb 11, 2025
@filev94 filev94 self-assigned this Feb 11, 2025
@filev94 filev94 mentioned this issue Feb 12, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature
Projects
None yet
Development

No branches or pull requests

1 participant