Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Group needs an atomic option #1503

Open
jbair06 opened this issue Jan 29, 2025 · 4 comments
Open

Transaction Group needs an atomic option #1503

jbair06 opened this issue Jan 29, 2025 · 4 comments

Comments

@jbair06
Copy link
Member

jbair06 commented Jan 29, 2025

Transaction group needs an option to make the group atomic. This would require that all transactions are submitted together, or none will be submitted. This will not ensure that all transactions will reach consensus. It is a pre-check only.

The check would require that all transactions that are not canceled have all the proper signatures before any of them are submitted.

@jbair06
Copy link
Member Author

jbair06 commented Jan 30, 2025

The option itself should read 'Require all signed', or similar.

@jbair06
Copy link
Member Author

jbair06 commented Jan 30, 2025

Discussion needed. Should this 'require all signed' be the default? Then let the creator cancel transactions as needed (if they aren't signed).

@jbair06
Copy link
Member Author

jbair06 commented Feb 4, 2025

After discussing the issue with @SimiHunjan, the plan will be to add the atomic check box. The default value will be unchecked.

Sequential groups are considered atomic, as well. It will therefor check the 'atomic' box, and disable it thus tying the state of atomic and sequential when sequential is selected.

@jbair06
Copy link
Member Author

jbair06 commented Feb 6, 2025

If a group is atomic, or sequential (which is also atomic), then the transaction group should likely appear in 'Ready to Execute' as a group, instead of individual transactions. This should be discussed further, for transactions groups that are atomic:

Transactions stay in a Transaction Group (appearing like they do in 'Ready to Sign')
or
Transactions appear as normal transactions but only if all transactions in the group are signed and ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant