Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor task and handler classes #1205

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

fix: Refactor task and handler classes #1205

wants to merge 19 commits into from

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented Jan 24, 2025 •
edited
Loading

Description

This pull request changes the following:

  • TBD

Related Issues

@Ivo-Yankov
wip: refactor classes
a6ee2da 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
Merge branch 'main' into 01195-refactor-task-and-handler-classes
6626cd2 
# Conflicts:
#	src/commands/cluster/handlers.ts
#	src/commands/cluster/tasks.ts
@Ivo-Yankov
fix: refactor cluster classes
63b214c 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
fix: refactor node classes
d06dd40 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov Ivo-Yankov self-assigned this Jan 24, 2025
@Ivo-Yankov
chore: format
9dfe512 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
fix: circular dependencies
9d0d72d 
Signed-off-by: Ivo Yankov <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   3s ⏱️ -1s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 39f9091. ± Comparison against base commit aa71ae8.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   13s ⏱️ -1s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 39f9091. ± Comparison against base commit aa71ae8.

♻️ This comment has been updated with latest results.

@Ivo-Yankov
fix: unit tests
7924da1 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
Merge branch 'main' into 01195-refactor-task-and-handler-classes
c8cb8ab 
# Conflicts:
#	src/commands/deployment.ts
#	src/core/config/remote/listr_config_tasks.ts
@Ivo-Yankov
fix: formatting
60fd0b4 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
fix: failing e2e test
39a3a90 
Signed-off-by: Ivo Yankov <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

E2E Test Report

 17 files  126 suites   1h 30m 40s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit 39a3a90.

♻️ This comment has been updated with latest results.

@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4ab4dd51 ✅ 91.51%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4ab4dd5) Report Missing Report Missing Report Missing
Head commit (39a3a90) 21857 18306 83.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1205) 530 485 91.51%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.50943% with 45 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (d60247a) to head (39a3a90).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/core/command_handler.ts 74.76% 27 Missing ⚠️
src/commands/cluster/handlers.ts 87.87% 4 Missing ⚠️
src/commands/cluster/tasks.ts 95.65% 4 Missing ⚠️
src/commands/node/handlers.ts 94.91% 3 Missing ⚠️
src/commands/base.ts 66.66% 2 Missing ⚠️
src/commands/explorer.ts 71.42% 2 Missing ⚠️
src/commands/mirror_node.ts 75.00% 1 Missing ⚠️
src/commands/network.ts 90.00% 1 Missing ⚠️
src/commands/relay.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   82.89%   82.93%   +0.03%     
==========================================
  Files          78       80       +2     
  Lines       21763    21857      +94     
  Branches     1824     1996     +172     
==========================================
+ Hits        18041    18127      +86     
+ Misses       3584     3560      -24     
- Partials      138      170      +32
Files with missing lines Coverage Δ
src/commands/cluster/configs.ts 84.67% <100.00%> (+0.11%) ⬆️
src/commands/cluster/index.ts 38.53% <100.00%> (-2.21%) ⬇️
src/commands/node/configs.ts 92.55% <100.00%> (+0.05%) ⬆️
src/commands/node/index.ts 17.09% <100.00%> (-5.55%) ⬇️
src/commands/node/tasks.ts 92.77% <100.00%> (+0.34%) ⬆️
src/core/config/remote/listr_config_tasks.ts 67.32% <100.00%> (+0.30%) ⬆️
src/core/config_builder.ts 100.00% <100.00%> (ø)
src/core/container_init.ts 95.00% <100.00%> (+0.33%) ⬆️
src/core/helpers.ts 83.09% <100.00%> (+1.22%) ⬆️
src/commands/mirror_node.ts 75.61% <75.00%> (ø)
... and 8 more

... and 8 files with indirect coverage changes

Impacted file tree graph

@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review January 27, 2025 13:38
@Ivo-Yankov Ivo-Yankov requested review from leninmehedy and a team as code owners January 27, 2025 13:38
@Ivo-Yankov Ivo-Yankov added the PR: Needs Approval A pull request that needs reviews and approvals. label Jan 27, 2025
jeromy-cannon
jeromy-cannon reviewed Jan 27, 2025
View reviewed changes
src/commands/base.ts Outdated Show resolved Hide resolved
@jeromy-cannon jeromy-cannon added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. and removed PR: Needs Approval A pull request that needs reviews and approvals. labels Jan 27, 2025
@Ivo-Yankov
chore: resolve todos
abcc89a 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
chore: add method scopes and return types
6902a5c 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
chore: code cleanup
aa5dc20 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
Merge branch 'main' into 01195-refactor-task-and-handler-classes
6ad50d4 
# Conflicts:
#	src/core/helpers.ts
@Ivo-Yankov
Merge branch 'main' into 01195-refactor-task-and-handler-classes
50766fd 
# Conflicts:
#	src/commands/cluster/handlers.ts
#	src/commands/cluster/index.ts
#	src/commands/cluster/tasks.ts
#	src/commands/explorer.ts
#	src/commands/mirror_node.ts
#	src/commands/node/handlers.ts
#	src/commands/node/index.ts
#	src/commands/node/tasks.ts
#	src/commands/relay.ts
@Ivo-Yankov
chore: resolve conflicts
7d86901 
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov
nit: add scopes
39f9091 
Signed-off-by: Ivo Yankov <[email protected]>
@jeromy-cannon jeromy-cannon added PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. PR: Checks Failed A pull request where the checks have failed. and removed PR: Unresolved Comments A pull request where there are comments and they need to be resolved. labels Jan 31, 2025
@Ivo-Yankov
Merge branch 'main' into 01195-refactor-task-and-handler-classes
17af09d 
# Conflicts:
#	src/commands/cluster/handlers.ts
#	src/commands/cluster/index.ts
#	src/commands/cluster/tasks.ts
#	src/commands/deployment.ts
#	src/commands/explorer.ts
#	src/commands/mirror_node.ts
#	src/commands/node/handlers.ts
#	src/commands/node/index.ts
#	src/commands/node/tasks.ts
#	src/commands/relay.ts
#	src/core/config/remote/listr_config_tasks.ts
#	src/core/container_init.ts
#	src/core/helpers.ts
#	test/e2e/e2e_node_util.ts
@Ivo-Yankov
chore: resolve conflicts
f408ec0 
Signed-off-by: Ivo Yankov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon left review comments

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Ivo-Yankov Ivo-Yankov

Labels
PR: Checks Failed A pull request where the checks have failed. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor task and handler classes
2 participants
@Ivo-Yankov @jeromy-cannon