Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map file doesn't match \r\n #82

Open
phntom opened this issue Oct 2, 2022 · 2 comments
Open

map file doesn't match \r\n #82

phntom opened this issue Oct 2, 2022 · 2 comments
Labels
question Further information is requested

Comments

@phntom
Copy link

phntom commented Oct 2, 2022

i suspect helm charts created with macosx have an issue where my ingress was not getting matched because the file had \r\n instead of \n like in the map file.
my workaround was to use the following mapping

  • deprecatedAPI: "apiVersion: networking.k8s.io/v1beta1\r\nkind: Ingress\r\n"
    newAPI: "apiVersion: networking.k8s.io/v1\nkind: Ingress\n"

but i'm sure a quick string replace would be a better solution for this.

@hickeyma
Copy link
Contributor

@phntom This is what the map file is for. It gives the flexibility to change string as need be. It is a simple workaround tool and as such want to keep the implementation as is.

Some context given previously in #75 (review).

@hickeyma hickeyma added the question Further information is requested label Jan 18, 2023
@ericyew
Copy link

ericyew commented Feb 10, 2023

Had this issue as well. Even worst, it's random premutation of \r and \n
"apiVersion: policy/v1beta1\r\nkind: PodDisruptionBudget\r\n"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants