Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow non-normalized inner transactions #17853

Closed
netopyr opened this issue Feb 12, 2025 · 0 comments
Closed

Disallow non-normalized inner transactions #17853

netopyr opened this issue Feb 12, 2025 · 0 comments

Comments

@netopyr
Copy link
Contributor

netopyr commented Feb 12, 2025

Inner transaction must use the normalized format: the TransactionBody is stored in Transaction.body and the SignatureMap in Transaction.sigMap.

If we encounter an inner transaction that does not comply with the normalized format, the transaction must fail. Please add this check and fix all tests. The right place for this check is probably AtomicBatchHandler.pureChecks().

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Feb 12, 2025
@netopyr netopyr moved this from 📋 Backlog to To Do in Services Team Feb 12, 2025
@netopyr netopyr added this to the v0.60 milestone Feb 12, 2025
@netopyr netopyr self-assigned this Feb 17, 2025
@netopyr netopyr moved this from To Do to 👷🏼‍♀️ In Progress in Services Team Feb 17, 2025
@netopyr netopyr moved this from 👷🏼‍♀️ In Progress to ✅ Done in Services Team Feb 19, 2025
@netopyr netopyr closed this as completed Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant