Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure raw bytes sent by the user are used for signature verification #17854

Open
netopyr opened this issue Feb 12, 2025 · 0 comments
Open

Ensure raw bytes sent by the user are used for signature verification #17854

netopyr opened this issue Feb 12, 2025 · 0 comments

Comments

@netopyr
Copy link
Contributor

netopyr commented Feb 12, 2025

Different Protobuf libraries serialize and deserialize protobuf files inconsistently, as the order of fields is not specified. To ensure that signature verifications succeed for transactions that store the TransactionBody in Transaction.body, we must use the raw bytes provided by the user.

Once access to the raw bytes has been added to PBJ, we have to modify the TransactionChecker.check() to use them instead of serializing the extracted TransactionBody.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Feb 12, 2025
@netopyr netopyr moved this from 📋 Backlog to To Do in Services Team Feb 12, 2025
@netopyr netopyr added this to the v0.60 milestone Feb 12, 2025
@netopyr netopyr self-assigned this Feb 20, 2025
@netopyr netopyr moved this from To Do to 👷🏼‍♀️ In Progress in Services Team Feb 20, 2025
@netopyr netopyr moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team Feb 20, 2025
@netopyr netopyr moved this from 👀 In Review to ✅ Done in Services Team Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant