chore: In CI @HapiTests, use spec name as default memo
#17870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <[email protected]>
david-bakin-sl
previously approved these changes
Feb 12, 2025
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/HapiSpecSetup.java
Show resolved
Hide resolved
mhess-swl
previously approved these changes
Feb 12, 2025
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17870 +/- ##
============================================
- Coverage 69.01% 69.01% -0.01%
+ Complexity 23050 23048 -2
============================================
Files 2655 2655
Lines 99675 99675
Branches 10289 10289
============================================
- Hits 68795 68793 -2
- Misses 26981 26983 +2
Partials 3899 3899 see 1 file with indirect coverage changes |
Signed-off-by: Michael Tinker <[email protected]>
tinker-michaelj
dismissed stale reviews from mhess-swl and david-bakin-sl
via
f8c2e31
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/HapiSpec.java
Show resolved
Hide resolved
thomas-swirlds-labs
previously approved these changes
Feb 13, 2025
Signed-off-by: Michael Tinker <[email protected]>
…s-default-memo-in-ci
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
mhess-swl
previously approved these changes
Feb 19, 2025
Signed-off-by: Michael Tinker <[email protected]>
andrewb1269hg
previously approved these changes
Feb 19, 2025
netopyr
reviewed
Feb 19, 2025
hedera-node/hedera-app/src/main/java/com/hedera/node/app/info/StateNetworkInfo.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/info/StateNetworkInfo.java
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <[email protected]>
Neeharika-Sompalli
approved these changes
Feb 19, 2025
mhess-swl
approved these changes
Feb 19, 2025
andrewb1269hg
approved these changes
Feb 19, 2025
tinker-michaelj
deleted the
17869-use-spec-name-as-default-memo-in-ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
@HapiTestname as default memo for involved transactions #17869