chore: Cryptography better loading #17882
Merged
+80
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mxtartaglia <[email protected]>
mxtartaglia-sl
requested review from
abies,
timo0,
IvanKavaldzhiev,
lpetrovic05,
mustafauzunn and
timfn-hg
mxtartaglia-sl
changed the title
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17882 +/- ##
=========================================
Coverage 69.01% 69.02%
- Complexity 23050 23053 +3
=========================================
Files 2655 2655
Lines 99675 99683 +8
Branches 10289 10290 +1
=========================================
+ Hits 68795 68802 +7
- Misses 26981 26984 +3
+ Partials 3899 3897 -2
... and 8 files with indirect coverage changes |
lpetrovic05
previously approved these changes
Feb 13, 2025
timfn-hg
previously approved these changes
Feb 13, 2025
edward-swirldslabs
previously approved these changes
Feb 13, 2025
.../swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/EnhancedKeyStoreLoader.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mxtartaglia <[email protected]>
mxtartaglia-sl
dismissed stale reviews from edward-swirldslabs, timfn-hg, and lpetrovic05
via
7285f97
lpetrovic05
previously approved these changes
Feb 14, 2025
edward-swirldslabs
previously approved these changes
Feb 14, 2025
Signed-off-by: Mustafa Uzun <[email protected]>
…1-chore-better-loadig-cryptography
mustafauzunn
dismissed stale reviews from lpetrovic05 and edward-swirldslabs
via
62b220d
mustafauzunn
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fix helps with better reporting cases where the cryptography material for a node is not present.
Related issue(s):
Fixes #17871