Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #17726 to use EntityIdFactory instead of depending on the HederaConfig #17877

Closed
vtronkov opened this issue Feb 13, 2025 · 0 comments · Fixed by #17906
Closed

Refactor #17726 to use EntityIdFactory instead of depending on the HederaConfig #17877

vtronkov opened this issue Feb 13, 2025 · 0 comments · Fixed by #17906
Assignees
@vtronkov
Milestone
v0.60

Comments

@vtronkov
Copy link
Contributor

vtronkov commented Feb 13, 2025 •
edited
Loading

Our initial implementation of the epic was to get access to HederaConfig and get the shard/realm from there. Michael T. created this story #17822 introducing EntityIdFactory that encasulates the creation of entities with the correct shard/realm.

Get through the changes in #17726 and refactor them to use the new EntityIdFactory objects instead of relying directly on HederaConfig:
@vtronkov vtronkov changed the title Refactor #17726 to use EntityIdFactory instead of depending on the HederaConfig Refactor #17726 to use EntityIdFactory instead of depending on the HederaConfig Feb 13, 2025
@vtronkov vtronkov self-assigned this Feb 13, 2025
@vtronkov vtronkov added this to the v0.60 milestone Feb 13, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Feb 13, 2025
@vtronkov vtronkov moved this from 📋 Backlog to 👷🏼‍♀️ In Progress in Services Team Feb 13, 2025
@vtronkov vtronkov mentioned this issue Feb 14, 2025
Merged
@vtronkov vtronkov moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team Feb 19, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Services Team Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtronkov vtronkov

Labels
None yet
Projects
None yet
Milestone
v0.60
1 participant
@vtronkov