refactor: #17726 to use EntityIdFactory instead of depending on the HederaConfig #17906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
…yIdFactory # Conflicts: # hedera-node/hedera-app-spi/src/testFixtures/java/com/hedera/node/app/spi/fixtures/ids/FakeEntityIdFactoryImpl.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/ids/AppEntityIdFactory.java # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/staking/EndOfStakingPeriodUpdater.java # platform-sdk/swirlds-state-api/src/main/java/com/swirlds/state/lifecycle/EntityIdFactory.java
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
povolev15
reviewed
Feb 19, 2025
.../hedera/node/app/service/token/impl/test/handlers/staking/StakingRewardsHandlerImplTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Valentin Tronkov <[email protected]>
povolev15
previously approved these changes
Feb 19, 2025
iwsimon
previously approved these changes
Feb 19, 2025
thenswan
previously approved these changes
Feb 19, 2025
…to-use-EntityIdFactory # Conflicts: # hedera-node/hedera-app-spi/src/testFixtures/java/com/hedera/node/app/spi/fixtures/ids/FakeEntityIdFactoryImpl.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/ids/AppEntityIdFactory.java # platform-sdk/swirlds-state-api/src/main/java/com/swirlds/state/lifecycle/EntityIdFactory.java
povolev15
dismissed stale reviews from thenswan, iwsimon, and themself
via
92d9f88
povolev15
previously approved these changes
Feb 19, 2025
Signed-off-by: Valentin Tronkov <[email protected]>
thenswan
previously approved these changes
Feb 19, 2025
edward-swirldslabs
previously approved these changes
Feb 19, 2025
…xposing it from the interface Signed-off-by: Valentin Tronkov <[email protected]>
vtronkov
dismissed stale reviews from edward-swirldslabs and thenswan
via
9c0ad04
vtronkov
requested review from
thenswan,
povolev15,
iwsimon and
edward-swirldslabs
thenswan
approved these changes
Feb 20, 2025
lpetrovic05
approved these changes
Feb 20, 2025
povolev15
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactoring #17726 to use
EntityIdFactoryinstead ofHederaConfigRelated issue(s):
Fixes #17877